lkml.org 
[lkml]   [2021]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH misc] misc: Add Renesas Synchronization Management Unit (SMU) support
Date
> On Wed, Sep 15, 2021 at 02:42:55PM +0000, Min Li wrote:
> > > > > > +/*
> > > > > > + * RSMU IOCTL List
> > > > > > + */
> > > > > > +#define RSMU_MAGIC '?'
> > > > >
> > > > > Where did you get this value from?
> > > > >
> > > > > Where did you reserve it?
> > > >
> > > > No I didn't reserve it. I checked other code and they all seem to
> > > > use a random character
> > >
> > > That's not the best way to do this.
> > >
> > > Why do you need ioctls at all anyway? What userspace tools will be
> > > accessing this driver? Do you have a link to where they are located at?
> >
> > Hi Greg
> >
> > The userspace tool is called PCM4L (PTP Clock Manager for Linux) from
> > Renesas
> >
> > https://www.renesas.com/us/en/software-tool/ptp-clock-manager-linux
> >
> > But the functions of this misc driver is not ptp related. It is meant
> > for being called by pcm4l to support GNSS assisted partial timing
> > support (APTS), which doesn't have abstracted/dedicated Linux Kernel
> API's. That is why I went for IOCTL in the first place.
>
> Why not work on a real set of apis for this type of thing so that all devices of
> this type will work properly?
>
> thanks,
>
> greg k-h

Hi Greg

That plan is on our roadmap. On the other hand, this is a new area that different company has its
own hw/sw solution and it takes time to abstract functions to kernel. Also, our APTS first release
was already out. Right now we are actively developing another release that we will try out best to
come up with better solution.

\
 
 \ /
  Last update: 2021-09-15 17:01    [W:0.086 / U:25.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site