Messages in this thread | | | Subject | Re: [PATCH 1/2] pwm: renesas-tpu: better errno for impossible rates | From | Sergei Shtylyov <> | Date | Wed, 15 Sep 2021 12:36:30 +0300 |
| |
On 15.09.2021 9:55, Wolfram Sang wrote:
> From: Duc Nguyen <duc.nguyen.ub@renesas.com> > > ENOTSUP has confused users. EINVAL has been considered clearer. Change > the errno, we were the only ones using ENOTSUP in this subsystem anyhow.
It's ENOTSUPP in the code. :-)
> > Signed-off-by: Duc Nguyen <duc.nguyen.ub@renesas.com> > [wsa: split and reworded commit message] > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/pwm/pwm-renesas-tpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c > index 4381df90a527..754440194650 100644 > --- a/drivers/pwm/pwm-renesas-tpu.c > +++ b/drivers/pwm/pwm-renesas-tpu.c > @@ -269,7 +269,7 @@ static int tpu_pwm_config(struct pwm_chip *chip, struct pwm_device *_pwm, > > if (prescaler == ARRAY_SIZE(prescalers) || period == 0) { > dev_err(&tpu->pdev->dev, "clock rate mismatch\n"); > - return -ENOTSUPP; > + return -EINVAL; > } > > if (duty_ns) {
MBR, Sergei
| |