Messages in this thread | | | Date | Wed, 15 Sep 2021 10:05:37 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH 05/16] tty: remove file from tty_mode_ioctl |
| |
On 14.09.2021 11:11:23, Jiri Slaby wrote: > The only user of 'file' parameter in tty_mode_ioctl is a BUG_ON check. > Provided it never crashed for anyone, it's an overkill to pass the > parameter to tty_mode_ioctl only for this check. > > If we wanted to check 'file' there, we should handle it in more graceful > way anyway. Not by a BUG == crash. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Wolfgang Grandegger <wg@grandegger.com> > Cc: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Andreas Koensgen <ajk@comnets.uni-bremen.de> > Cc: Paul Mackerras <paulus@samba.org> > --- > drivers/net/can/slcan.c | 2 +-
For the slcan.c: Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |