Messages in this thread | | | Date | Wed, 15 Sep 2021 10:05:05 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH 04/16] tty: make tty_ldisc_ops::hangup return void |
| |
On 14.09.2021 11:11:22, Jiri Slaby wrote: > The documentation says that the return value of tty_ldisc_ops::hangup > hook is ignored. And it really is, so there is no point for its return > type to be int. Switch it to void and all the hooks too. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Wolfgang Grandegger <wg@grandegger.com> > Cc: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.com> > Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com> > --- > Documentation/driver-api/serial/tty.rst | 2 +- > drivers/input/serio/serport.c | 3 +-- > drivers/net/can/slcan.c | 3 +--
For the slcan.c: Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |