Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH -next] irqdomain: fix overflow error | Date | Wed, 15 Sep 2021 09:49:15 +0200 |
| |
On Wed, Sep 15 2021 at 10:03, Bixuan Cui wrote: > On 2021/9/14 19:56, Thomas Gleixner wrote: > > And kernel/irq/irqdomain.c > struct irq_domain *irq_domain_create_simple(struct fwnode_handle *fwnode, > unsigned int size, > unsigned int first_irq, > const struct irq_domain_ops *ops, > void *host_data) > { > struct irq_domain *domain; > > domain = __irq_domain_add(fwnode, size, size, 0, ops, host_data); > > All 'size' passed to __irq_domain_add() are unsigned int. > > So I think it's more appropriate to replace it with unsigned int.
Appropriate is not really a technical reason. Making the code consistent is.
But that has nothing to do with the completely bogus compiler warning in the changelog you provided.
Thanks,
tglx
| |