lkml.org 
[lkml]   [2021]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/2] PCI: hv: Make the code arch neutral
On Mon, Sep 13, 2021 at 05:36:46PM +0000, Sunil Muthuswamy wrote:
> This patch makes the Hyper-V vPCI code architectural neutral by
> moving the architectural dependent pieces into arch specific
> code. This allows for the implementation of Hyper-V vPCI for
> other architecture such as ARM64.
>
> There are no functional changes expected from this patch.
>
> Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>

This overall looks good to me, I think you may want to base on 5.15-rc1
which has Michael's and my patches on which this patchset depends.

A small nit below:

[...]
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 62dbe98d1fe1..b7213b57b4ec 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -44,8 +44,8 @@
> #include <linux/delay.h>
> #include <linux/semaphore.h>
> #include <linux/irqdomain.h>
> -#include <asm/irqdomain.h>
> -#include <asm/apic.h>
> +//#include <asm/irqdomain.h>
> +//#include <asm/apic.h>

remove the commented out #include too.

Regards,
Boqun

> #include <linux/irq.h>
> #include <linux/msi.h>
> #include <linux/hyperv.h>
[...]

\
 
 \ /
  Last update: 2021-09-16 03:48    [W:0.041 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site