lkml.org 
[lkml]   [2021]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 15/16] tty: the rest, stop using tty_flip_buffer_push
    From
    Date
    On Tue, 2021-09-14 at 11:14 +0200, Jiri Slaby wrote:
    > Since commit a9c3f68f3cd8d (tty: Fix low_latency BUG) in 2014,
    > tty_flip_buffer_push() is only a wrapper to tty_schedule_flip(). We
    > are
    > going to remove the former, so call the latter directly in the couple
    > of
    > remaining users.
    >
    > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    > Cc: Arnd Bergmann <arnd@arndb.de>
    > Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
    > Cc: Jens Taprogge <jens.taprogge@taprogge.org>
    > Cc: Scott Branden <scott.branden@broadcom.com>
    > Cc: Ulf Hansson <ulf.hansson@linaro.org>
    > Cc: "David S. Miller" <davem@davemloft.net>
    > Cc: Jakub Kicinski <kuba@kernel.org>
    > Cc: Marcel Holtmann <marcel@holtmann.org>
    > Cc: Johan Hedberg <johan.hedberg@gmail.com>
    > Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
    > ---
    >  drivers/char/pcmcia/synclink_cs.c | 2 +-
    >  drivers/ipack/devices/ipoctal.c   | 2 +-
    >  drivers/misc/bcm-vk/bcm_vk_tty.c  | 2 +-
    >  drivers/mmc/core/sdio_uart.c      | 2 +-
    >  drivers/net/usb/hso.c             | 2 +-
    >  net/bluetooth/rfcomm/tty.c        | 4 ++--
    >  6 files changed, 7 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/char/pcmcia/synclink_cs.c
    > b/drivers/char/pcmcia/synclink_cs.c
    > index 78baba55a8b5..29a7a89ee58d 100644
    > --- a/drivers/char/pcmcia/synclink_cs.c
    > +++ b/drivers/char/pcmcia/synclink_cs.c
    > @@ -952,7 +952,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int
    > tcd)
    >         }
    >  
    >         if (work)
    > -               tty_flip_buffer_push(port);
    > +               tty_schedule_flip(port);
    >  }
    >  
    >  
    > diff --git a/drivers/ipack/devices/ipoctal.c
    > b/drivers/ipack/devices/ipoctal.c
    > index c14e65a5d38f..714e2b8c551f 100644
    > --- a/drivers/ipack/devices/ipoctal.c
    > +++ b/drivers/ipack/devices/ipoctal.c
    > @@ -184,7 +184,7 @@ static void ipoctal_irq_rx(struct ipoctal_channel
    > *channel, u8 sr)
    >                 sr = ioread8(&channel->regs->r.sr);
    >         } while (isr & channel->isr_rx_rdy_mask);
    >  
    > -       tty_flip_buffer_push(port);
    > +       tty_schedule_flip(port);
    >  }
    >  

    For ipoctal changes:

    Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

    Sam

    >  static void ipoctal_irq_tx(struct ipoctal_channel *channel)
    > diff --git a/drivers/misc/bcm-vk/bcm_vk_tty.c b/drivers/misc/bcm-
    > vk/bcm_vk_tty.c
    > index 1b6076a89ca6..328109a719be 100644
    > --- a/drivers/misc/bcm-vk/bcm_vk_tty.c
    > +++ b/drivers/misc/bcm-vk/bcm_vk_tty.c
    > @@ -114,7 +114,7 @@ static void bcm_vk_tty_wq_handler(struct
    > work_struct *work)
    >                 }
    >  
    >                 if (count) {
    > -                       tty_flip_buffer_push(&vktty->port);
    > +                       tty_schedule_flip(&vktty->port);
    >  
    >                         /* Update read offset from shadow register to
    > card */
    >                         vkwrite32(vk, vktty->rd, BAR_1,
    > diff --git a/drivers/mmc/core/sdio_uart.c
    > b/drivers/mmc/core/sdio_uart.c
    > index 04c0823e0359..55fc67bd0937 100644
    > --- a/drivers/mmc/core/sdio_uart.c
    > +++ b/drivers/mmc/core/sdio_uart.c
    > @@ -418,7 +418,7 @@ static void sdio_uart_receive_chars(struct
    > sdio_uart_port *port,
    >                 *status = sdio_in(port, UART_LSR);
    >         } while ((*status & UART_LSR_DR) && (max_count-- > 0));
    >  
    > -       tty_flip_buffer_push(&port->port);
    > +       tty_schedule_flip(&port->port);
    >  }
    >  
    >  static void sdio_uart_transmit_chars(struct sdio_uart_port *port)
    > diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
    > index 7dc1ef3f93c3..55ea64b162e1 100644
    > --- a/drivers/net/usb/hso.c
    > +++ b/drivers/net/usb/hso.c
    > @@ -2018,7 +2018,7 @@ static int put_rxbuf_data(struct urb *urb,
    > struct hso_serial *serial)
    >         if (count >= urb->actual_length) {
    >                 tty_insert_flip_string(&serial->port, urb-
    > >transfer_buffer,
    >                                        urb->actual_length);
    > -               tty_flip_buffer_push(&serial->port);
    > +               tty_schedule_flip(&serial->port);
    >         } else {
    >                 dev_warn(&serial->parent->usb->dev,
    >                          "dropping data, %d bytes lost\n", urb-
    > >actual_length);
    > diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c
    > index ebd78fdbd6e8..2a09637bdb00 100644
    > --- a/net/bluetooth/rfcomm/tty.c
    > +++ b/net/bluetooth/rfcomm/tty.c
    > @@ -618,7 +618,7 @@ static void rfcomm_dev_data_ready(struct
    > rfcomm_dlc *dlc, struct sk_buff *skb)
    >         BT_DBG("dlc %p len %d", dlc, skb->len);
    >  
    >         tty_insert_flip_string(&dev->port, skb->data, skb->len);
    > -       tty_flip_buffer_push(&dev->port);
    > +       tty_schedule_flip(&dev->port);
    >  
    >         kfree_skb(skb);
    >  }
    > @@ -677,7 +677,7 @@ static void rfcomm_tty_copy_pending(struct
    > rfcomm_dev *dev)
    >         rfcomm_dlc_unlock(dev->dlc);
    >  
    >         if (inserted > 0)
    > -               tty_flip_buffer_push(&dev->port);
    > +               tty_schedule_flip(&dev->port);
    >  }
    >  
    >  /* do the reverse of install, clearing the tty fields and releasing
    > the

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-09-14 14:37    [W:4.336 / U:0.664 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site