Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH 1/1] powerpc: Drop superfluous pci_dev_is_added() calls | Date | Wed, 15 Sep 2021 10:23:22 +1000 |
| |
Bjorn Helgaas <helgaas@kernel.org> writes: > On Fri, Sep 10, 2021 at 04:19:40PM +0200, Niklas Schnelle wrote: >> On powerpc, pci_dev_is_added() is called as part of SR-IOV fixups >> that are done under pcibios_add_device() which in turn is only called in >> pci_device_add() whih is called when a PCI device is scanned. >> >> Now pci_dev_assign_added() is called in pci_bus_add_device() which is >> only called after scanning the device. Thus pci_dev_is_added() is always >> false and can be dropped. >> >> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > Reviewed-by: Bjorn Helgaas <bhelgaas@google.com> > > This doesn't touch the PCI core, so maybe makes sense for you to take > it, Michael? But let me know if you think otherwise.
Yeah I'm happy to take it, thanks.
cheers
| |