Messages in this thread | | | Subject | Re: [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning | From | Randy Dunlap <> | Date | Mon, 13 Sep 2021 21:15:29 -0700 |
| |
On 1/14/21 11:40 PM, Palmer Dabbelt wrote: > From: Palmer Dabbelt <palmerdabbelt@google.com> > > cdn_dp_resume is only used under PM_SLEEP, and now that it's static an > unused function warning is triggered undner !PM_SLEEP. This > conditionally enables the function to avoid the warning. > > Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static") > Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com> > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index a4a45daf93f2..063a60d213ba 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1121,6 +1121,7 @@ static int cdn_dp_suspend(struct device *dev) > return ret; > } > > +#ifdef CONFIG_PM_SLEEP > static int cdn_dp_resume(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > @@ -1133,6 +1134,7 @@ static int cdn_dp_resume(struct device *dev) > > return 0; > } > +#endif > > static int cdn_dp_probe(struct platform_device *pdev) > { >
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Is someone going to merge this patch from January?
thanks. -- ~Randy
| |