lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 203/236] ath6kl: wmi: fix an error code in ath6kl_wmi_sync_point()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit fd6729ec534cffbbeb3917761e6d1fe6a412d3fe ]

    This error path is unlikely because of it checked for NULL and
    returned -ENOMEM earlier in the function. But it should return
    an error code here as well if we ever do hit it because of a
    race condition or something.

    Fixes: bdcd81707973 ("Add ath6kl cleaned up driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20210813113438.GB30697@kili
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath6kl/wmi.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c
    index dbc47702a268..5bacddee8344 100644
    --- a/drivers/net/wireless/ath/ath6kl/wmi.c
    +++ b/drivers/net/wireless/ath/ath6kl/wmi.c
    @@ -2504,8 +2504,10 @@ static int ath6kl_wmi_sync_point(struct wmi *wmi, u8 if_idx)
    goto free_data_skb;

    for (index = 0; index < num_pri_streams; index++) {
    - if (WARN_ON(!data_sync_bufs[index].skb))
    + if (WARN_ON(!data_sync_bufs[index].skb)) {
    + ret = -ENOMEM;
    goto free_data_skb;
    + }

    ep_id = ath6kl_ac2_endpoint_id(wmi->parent_dev,
    data_sync_bufs[index].
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 15:52    [W:3.838 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site