lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 219/236] io_uring: IORING_OP_WRITE needs hash_reg_file set
    Date
    From: Jens Axboe <axboe@kernel.dk>

    commit 7b3188e7ed54102a5dcc73d07727f41fb528f7c8 upstream.

    During some testing, it became evident that using IORING_OP_WRITE doesn't
    hash buffered writes like the other writes commands do. That's simply
    an oversight, and can cause performance regressions when doing buffered
    writes with this command.

    Correct that and add the flag, so that buffered writes are correctly
    hashed when using the non-iovec based write command.

    Cc: stable@vger.kernel.org
    Fixes: 3a6820f2bb8a ("io_uring: add non-vectored read/write commands")
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/io_uring.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/io_uring.c
    +++ b/fs/io_uring.c
    @@ -889,6 +889,7 @@ static const struct io_op_def io_op_defs
    },
    [IORING_OP_WRITE] = {
    .needs_file = 1,
    + .hash_reg_file = 1,
    .unbound_nonreg_file = 1,
    .pollout = 1,
    .async_size = sizeof(struct io_async_rw),

    \
     
     \ /
      Last update: 2021-09-13 15:50    [W:4.029 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site