lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 149/236] usb: gadget: udc: at91: add IRQ check
    Date
    From: Sergey Shtylyov <s.shtylyov@omp.ru>

    [ Upstream commit 50855c31573b02963f0aa2aacfd4ea41c31ae0e0 ]

    The driver neglects to check the result of platform_get_irq()'s call and
    blithely passes the negative error codes to devm_request_irq() (which takes
    *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
    error code. Stop calling devm_request_irq() with the invalid IRQ #s.

    Fixes: 8b2e76687b39 ("USB: AT91 UDC updates, mostly power management")
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
    Acked-by: Felipe Balbi <balbi@kernel.org>
    Link: https://lore.kernel.org/r/6654a224-739a-1a80-12f0-76d920f87b6c@omp.ru
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/at91_udc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
    index eede5cedacb4..d9ad9adf7348 100644
    --- a/drivers/usb/gadget/udc/at91_udc.c
    +++ b/drivers/usb/gadget/udc/at91_udc.c
    @@ -1876,7 +1876,9 @@ static int at91udc_probe(struct platform_device *pdev)
    clk_disable(udc->iclk);

    /* request UDC and maybe VBUS irqs */
    - udc->udp_irq = platform_get_irq(pdev, 0);
    + udc->udp_irq = retval = platform_get_irq(pdev, 0);
    + if (retval < 0)
    + goto err_unprepare_iclk;
    retval = devm_request_irq(dev, udc->udp_irq, at91_udc_irq, 0,
    driver_name, udc);
    if (retval) {
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 15:46    [W:5.301 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site