lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 028/236] crypto: qat - do not ignore errors from enable_vf2pf_comms()
    Date
    From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

    [ Upstream commit 5147f0906d50a9d26f2b8698cd06b5680e9867ff ]

    The function adf_dev_init() ignores the error code reported by
    enable_vf2pf_comms(). If the latter fails, e.g. the VF is not compatible
    with the pf, then the load of the VF driver progresses.
    This patch changes adf_dev_init() so that the error code from
    enable_vf2pf_comms() is returned to the caller.

    Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
    Reviewed-by: Marco Chiappero <marco.chiappero@intel.com>
    Reviewed-by: Fiona Trahe <fiona.trahe@intel.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/qat/qat_common/adf_init.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/crypto/qat/qat_common/adf_init.c b/drivers/crypto/qat/qat_common/adf_init.c
    index 42029153408e..5c78433d19d4 100644
    --- a/drivers/crypto/qat/qat_common/adf_init.c
    +++ b/drivers/crypto/qat/qat_common/adf_init.c
    @@ -61,6 +61,7 @@ int adf_dev_init(struct adf_accel_dev *accel_dev)
    struct service_hndl *service;
    struct list_head *list_itr;
    struct adf_hw_device_data *hw_data = accel_dev->hw_device;
    + int ret;

    if (!hw_data) {
    dev_err(&GET_DEV(accel_dev),
    @@ -127,9 +128,9 @@ int adf_dev_init(struct adf_accel_dev *accel_dev)
    }

    hw_data->enable_error_correction(accel_dev);
    - hw_data->enable_vf2pf_comms(accel_dev);
    + ret = hw_data->enable_vf2pf_comms(accel_dev);

    - return 0;
    + return ret;
    }
    EXPORT_SYMBOL_GPL(adf_dev_init);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 15:37    [W:2.792 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site