Messages in this thread | | | Date | Mon, 13 Sep 2021 20:30:50 -0700 | Subject | Re: [PATCH v2 1/3] scsi: ufs: introduce vendor isr | From | Bart Van Assche <> |
| |
On 9/13/21 00:55, Kiwoong Kim wrote: > +static inline irqreturn_t > +ufshcd_vendor_isr_def(struct ufs_hba *hba) > +{ > + return IRQ_NONE; > +}
Since "static inline irqreturn_t ufshcd_vendor_isr_def(struct ufs_hba *hba)" occupies less than 80 columns please use a single line for the declaration of this function. Additionally, please leave out the "inline" keyword since modern compilers are good at deciding when to inline a function and when not.
Thanks,
Bart.
| |