lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5.14 018/334] nbd: add the check to prevent overflow in __nbd_ioctl()
    On Mon, Sep 13, 2021 at 2:15 PM Nick Desaulniers
    <ndesaulniers@google.com> wrote:
    >
    > Sorry wrong diff:

    Well, this second diff was seriously whitespace-damaged and hard to
    read, but while it seems to be the same number of lines, it sure looks
    a lot more readable in this format.

    Except I think that

    default: dividend / divisor);

    should really have parentheses around both of those macro arguments.

    That's a preexisting problem, but it should be fixed while at it.

    I'm also not sure why that (again, preexisting) BUILD_BUG_ON_MSG()
    only checks the size of the dividend, not the divisor. Very strange.
    But probably not worth worrying about.

    Linus

    \
     
     \ /
      Last update: 2021-09-14 01:19    [W:3.297 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site