Messages in this thread | | | From | Philip Chen <> | Date | Mon, 13 Sep 2021 14:35:14 -0700 | Subject | Re: [PATCH 2/2] drm/bridge: parade-ps8640: Add support for AUX channel |
| |
On Thu, Sep 9, 2021 at 12:07 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Philip Chen (2021-09-09 11:15:27) > > On Wed, Sep 8, 2021 at 3:27 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > > > Quoting Philip Chen (2021-09-08 11:18:06) > > > > > > > + > > > > + data = (len - 1) & AUX_LENGTH_MASK; > > > > + regmap_write(map, PAGE0_AUX_LENGTH, data); > > > > + > > > > + if (request == DP_AUX_NATIVE_WRITE || request == DP_AUX_I2C_WRITE) { > > > > + ret = regmap_noinc_write(map, PAGE0_AUX_WDATA, buf, len); > > > > + if (ret < 0) { > > > > + DRM_ERROR("failed to write PAGE0_AUX_WDATA"); > > > > > > Needs a newline. > > Adding an empty line here doesn't look like a common Linux style? > > Could you point me to any similar instances in the Linux codebase? > > Sorry. I meant on the DRM_ERROR message itself. Add a newline.
Fixed in v2. PTAL.
| |