Messages in this thread | | | Date | Mon, 13 Sep 2021 23:19:32 +0300 | Subject | Re: [PATCH v4 17/18] staging: r8188eu: Shorten calls chain of rtw_read8/16/32() | From | Pavel Skripkin <> |
| |
On 9/13/21 21:10, Fabio M. De Francesco wrote: > Shorten the calls chain of rtw_read8/16/32() down to the actual reads. > For this purpose unify the three usb_read8/16/32 into the new > usb_read(); make the latter parameterizable with 'size'; embed most of > the code of usbctrl_vendorreq() into usb_read() and use in it the new > usb_control_msg_recv() API of USB Core. > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Co-developed-by: Pavel Skripkin <paskripkin@gmail.com> > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > --- > > v3->v4: > Make some changes according to a first review of Greg > Kroah-Hartman; remove unnecessary while loop and a couple of > 'if' test; handle the errors returned by usb_control_msg_recv() > v2->v3: > No changes. > v1->v2: > No changes. >
Hi, maintainers and reviewers!
We have just noticed, that 17 and 18 patches in this series contain logic error, so, please, don't waste time reviewing them.
v5 will be posted soon :)
With regards, Pavel Skripkin
| |