lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 204/334] usb: misc: brcmstb-usb-pinmap: add IRQ check
    Date
    From: Sergey Shtylyov <s.shtylyov@omp.ru>

    [ Upstream commit 711087f342914e831269438ff42cf59bb0142c71 ]

    The driver neglects to check the result of platform_get_irq()'s call and
    blithely passes the negative error codes to devm_request_irq() (which takes
    *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
    error code. Stop calling devm_request_irq() with the invalid IRQ #s.

    Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
    Link: https://lore.kernel.org/r/806d0b1a-365b-93d9-3fc1-922105ca5e61@omp.ru
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/misc/brcmstb-usb-pinmap.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
    index 336653091e3b..2b2019c19cde 100644
    --- a/drivers/usb/misc/brcmstb-usb-pinmap.c
    +++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
    @@ -293,6 +293,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev)

    /* Enable interrupt for out pins */
    irq = platform_get_irq(pdev, 0);
    + if (irq < 0)
    + return irq;
    err = devm_request_irq(&pdev->dev, irq,
    brcmstb_usb_pinmap_ovr_isr,
    IRQF_TRIGGER_RISING,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:42    [W:3.106 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site