lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 082/334] drm/panfrost: Fix missing clk_disable_unprepare() on error in panfrost_clk_init()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit f42498705965bd4b026953c1892c686d8b1138e4 ]

    Fix the missing clk_disable_unprepare() before return
    from panfrost_clk_init() in the error handling case.

    Fixes: b681af0bc1cc ("drm: panfrost: add optional bus_clock")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Reviewed-by: Steven Price <steven.price@arm.com>
    Signed-off-by: Steven Price <steven.price@arm.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210608143856.4154766-1-weiyongjun1@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/panfrost/panfrost_device.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
    index 125ed973feaa..a2a09c51eed7 100644
    --- a/drivers/gpu/drm/panfrost/panfrost_device.c
    +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
    @@ -54,7 +54,8 @@ static int panfrost_clk_init(struct panfrost_device *pfdev)
    if (IS_ERR(pfdev->bus_clock)) {
    dev_err(pfdev->dev, "get bus_clock failed %ld\n",
    PTR_ERR(pfdev->bus_clock));
    - return PTR_ERR(pfdev->bus_clock);
    + err = PTR_ERR(pfdev->bus_clock);
    + goto disable_clock;
    }

    if (pfdev->bus_clock) {
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:30    [W:4.469 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site