lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 027/334] libata: fix ata_host_start()
    Date
    From: Damien Le Moal <damien.lemoal@wdc.com>

    [ Upstream commit 355a8031dc174450ccad2a61c513ad7222d87a97 ]

    The loop on entry of ata_host_start() may not initialize host->ops to a
    non NULL value. The test on the host_stop field of host->ops must then
    be preceded by a check that host->ops is not NULL.

    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Link: https://lore.kernel.org/r/20210816014456.2191776-3-damien.lemoal@wdc.com
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ata/libata-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
    index 61c762961ca8..44f434acfce0 100644
    --- a/drivers/ata/libata-core.c
    +++ b/drivers/ata/libata-core.c
    @@ -5573,7 +5573,7 @@ int ata_host_start(struct ata_host *host)
    have_stop = 1;
    }

    - if (host->ops->host_stop)
    + if (host->ops && host->ops->host_stop)
    have_stop = 1;

    if (have_stop) {
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:25    [W:3.230 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site