lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 220/300] octeontx2-pf: Dont install VLAN offload rule if netdev is down
    Date
    From: Sunil Goutham <sgoutham@marvell.com>

    [ Upstream commit 05209e3570e452cdaa644e8398a8875b6a91051d ]

    Whenever user changes interface MAC address both default DMAC based
    MCAM rule and VLAN offload (for strip) rules are updated with new
    MAC address. To update or install VLAN offload rule PF driver needs
    interface's receive channel info, which is retrieved from admin
    function at the time of NIXLF initialization.

    If user changes MAC address before interface is UP, VLAN offload rule
    installation will fail and throw error as receive channel is not valid.
    To avoid this, skip VLAN offload rule installation if netdev is not UP.
    This rule will anyway be reinslatted as part of open() call.

    Fixes: fd9d7859db6c ("octeontx2-pf: Implement ingress/egress VLAN offload")
    Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
    index 16ba457197a2..871404f3b8d3 100644
    --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
    +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
    @@ -208,7 +208,8 @@ int otx2_set_mac_address(struct net_device *netdev, void *p)
    if (!otx2_hw_set_mac_addr(pfvf, addr->sa_data)) {
    memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
    /* update dmac field in vlan offload rule */
    - if (pfvf->flags & OTX2_FLAG_RX_VLAN_SUPPORT)
    + if (netif_running(netdev) &&
    + pfvf->flags & OTX2_FLAG_RX_VLAN_SUPPORT)
    otx2_install_rxvlan_offload_flow(pfvf);
    } else {
    return -EPERM;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:13    [W:2.834 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site