lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 143/300] leds: rt8515: Put fwnode in any case during ->probe()
    Date
    From: Andy Shevchenko <andy.shevchenko@gmail.com>

    [ Upstream commit 8aa41952ef245449df79100e1942b5e6288b098a ]

    fwnode_get_next_available_child_node() bumps a reference counting of
    a returned variable. We have to balance it whenever we return to
    the caller.

    Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver")
    Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/leds/flash/leds-rt8515.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8515.c
    index 590bfa180d10..44904fdee3cc 100644
    --- a/drivers/leds/flash/leds-rt8515.c
    +++ b/drivers/leds/flash/leds-rt8515.c
    @@ -343,8 +343,9 @@ static int rt8515_probe(struct platform_device *pdev)

    ret = devm_led_classdev_flash_register_ext(dev, fled, &init_data);
    if (ret) {
    - dev_err(dev, "can't register LED %s\n", led->name);
    + fwnode_handle_put(child);
    mutex_destroy(&rt->lock);
    + dev_err(dev, "can't register LED %s\n", led->name);
    return ret;
    }

    @@ -362,6 +363,7 @@ static int rt8515_probe(struct platform_device *pdev)
    */
    }

    + fwnode_handle_put(child);
    return 0;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:05    [W:4.090 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site