lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 092/300] drm/of: free the iterator object on failure
    Date
    From: Steven Price <steven.price@arm.com>

    [ Upstream commit 6f9223a56fabc840836b49de27dc7b27642c6a32 ]

    When bailing out due to the sanity check the iterator value needs to be
    freed because the early return prevents for_each_child_of_node() from
    doing the dereference itself.

    Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
    Signed-off-by: Steven Price <steven.price@arm.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210714143300.20632-1-steven.price@arm.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/drm_of.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
    index 197c57477344..997b8827fed2 100644
    --- a/drivers/gpu/drm/drm_of.c
    +++ b/drivers/gpu/drm/drm_of.c
    @@ -331,8 +331,10 @@ static int drm_of_lvds_get_remote_pixels_type(
    * configurations by passing the endpoints explicitly to
    * drm_of_lvds_get_dual_link_pixel_order().
    */
    - if (!current_pt || pixels_type != current_pt)
    + if (!current_pt || pixels_type != current_pt) {
    + of_node_put(endpoint);
    return -EINVAL;
    + }
    }

    return pixels_type;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:02    [W:4.075 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site