Messages in this thread | | | From | Yafang Shao <> | Date | Sat, 11 Sep 2021 22:47:52 +0800 | Subject | Re: [PATCH peterz-queue:sched/core] sched: fix build warning with W=1 |
| |
On Sat, Sep 11, 2021 at 8:22 PM Peter Zijlstra <peterz@infradead.org> wrote: > > On Sat, Sep 11, 2021 at 08:25:05AM +0000, Yafang Shao wrote: > > kernel test robot reported some build warnings with W=1 as below, > > > > kernel/sched/fair.c:892:34: warning: variable 'stats' set but not used > > kernel/sched/core.c:10238:42: warning: variable 'stats' set but not used > > kernel/sched/fair.c:893:29: warning: variable 'p' set but not used > > kernel/sched/rt.c:1292:29: warning: variable 'p' set but not used > > kernel/sched/deadline.c:1486:34: warning: variable 'stats' set but not used > > arch/nds32/include/asm/current.h:10:13: warning: variable '$r25' set but not used > > > > These warnings happen when CONFIG_SCHEDSTATS is not set, in which > > case the schedstat_* functions will be none. We should add > > '__maybe_unused' to fix it > > I really hate all of this, I think the compiler is just being unhelpful > in the extreme. Also, I spupose the warning is in W=1 for a reason, > let's just completely ignore all of this.
Got it. Thanks for the review.
-- Thanks Yafang
| |