lkml.org 
[lkml]   [2021]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 15/32] PCI: cadence: Use bitfield for *quirk_retrain_flag* instead of bool
    Date
    From: Kishon Vijay Abraham I <kishon@ti.com>

    [ Upstream commit f4455748b2126a9ba2bcc9cfb2fbcaa08de29bb2 ]

    No functional change. As we are intending to add additional 1-bit
    members in struct j721e_pcie_data/struct cdns_pcie_rc, use bitfields
    instead of bool since it takes less space. As discussed in [1],
    the preference is to use bitfileds instead of bool inside structures.

    [1] -> https://lore.kernel.org/linux-fsdevel/CA+55aFzKQ6Pj18TB8p4Yr0M4t+S+BsiHH=BJNmn=76-NcjTj-g@mail.gmail.com/

    Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
    Link: https://lore.kernel.org/r/20210811123336.31357-2-kishon@ti.com
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/cadence/pci-j721e.c | 2 +-
    drivers/pci/controller/cadence/pcie-cadence.h | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
    index 35e61048e133..0c5813b230b4 100644
    --- a/drivers/pci/controller/cadence/pci-j721e.c
    +++ b/drivers/pci/controller/cadence/pci-j721e.c
    @@ -66,7 +66,7 @@ enum j721e_pcie_mode {

    struct j721e_pcie_data {
    enum j721e_pcie_mode mode;
    - bool quirk_retrain_flag;
    + unsigned int quirk_retrain_flag:1;
    };

    static inline u32 j721e_pcie_user_readl(struct j721e_pcie *pcie, u32 offset)
    diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h
    index 30db2d68c17a..bc27d126f239 100644
    --- a/drivers/pci/controller/cadence/pcie-cadence.h
    +++ b/drivers/pci/controller/cadence/pcie-cadence.h
    @@ -303,7 +303,7 @@ struct cdns_pcie_rc {
    u32 vendor_id;
    u32 device_id;
    bool avail_ib_bar[CDNS_PCIE_RP_MAX_IB];
    - bool quirk_retrain_flag;
    + unsigned int quirk_retrain_flag:1;
    };

    /**
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-09-11 15:13    [W:2.312 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site