Messages in this thread | | | Date | Fri, 10 Sep 2021 17:07:47 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH 03/10] mm/ksm: remove old GCC 4.9+ check |
| |
On Fri, Sep 10, 2021 at 04:40:40PM -0700, Nick Desaulniers wrote: > The minimum supported version of GCC has been raised to GCC 5.1. > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
This is technically new for clang but arm64 allmodconfig does not complain.
> --- > mm/ksm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 025338128cd9..a5716fdec1aa 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -651,10 +651,8 @@ static void remove_node_from_stable_tree(struct stable_node *stable_node) > * from &migrate_nodes. This will verify that future list.h changes > * don't break STABLE_NODE_DUP_HEAD. Only recent gcc can handle it.
Probably worth removing the recent GCC comment.
> */ > -#if defined(GCC_VERSION) && GCC_VERSION >= 40903 > BUILD_BUG_ON(STABLE_NODE_DUP_HEAD <= &migrate_nodes); > BUILD_BUG_ON(STABLE_NODE_DUP_HEAD >= &migrate_nodes + 1); > -#endif > > if (stable_node->head == &migrate_nodes) > list_del(&stable_node->list); > -- > 2.33.0.309.g3052b89438-goog > >
| |