Messages in this thread | | | Date | Thu, 05 Aug 2021 18:17:32 +0200 | From | Paul Cercueil <> | Subject | Re: [PATCH v2 8/8] [RFC] drm/ingenic: convert to component framework for jz4780 hdmi |
| |
Hi Nikolaus and Laurent,
Le jeu., août 5 2021 at 18:07:20 +0200, H. Nikolaus Schaller <hns@goldelico.com> a écrit : > Hi Laurent, > >> Am 05.08.2021 um 17:04 schrieb Laurent Pinchart >> <laurent.pinchart@ideasonboard.com>: >> >> Hi Nikolaus, >> >> Thank you for the patch. >> >> On Thu, Aug 05, 2021 at 04:07:57PM +0200, H. Nikolaus Schaller >> wrote: >>> This patch attempts to convert the ingenic-dw-hdmi driver >>> into a version that uses the component framework. >> >> Why ? What problem would this solve ? > > Well, it was suggested in a v1 we did post several months ago. I have > not > looked up by whom and do not exactly remember the reasons. > > We now simply thought that it is common style since dome dw-hdmi > drivers > make use of it but some others don't. And we got it working without. > > If it is not needed/requested by anyone, we can drop it from v3 (or > add later).
I don't remember exactly TBH - the only reason to use a component is to have access to the main driver's "drm_device" structure. The IPU needs it for instance, to register planes; but I don't think this HDMI driver needs it as it registers a bridge.
Cheers, -Paul
| |