Messages in this thread | | | From | Waiman Long <> | Subject | Re: [patch 15/63] locking: Add base code for RT rw_semaphore and rwlock | Date | Thu, 5 Aug 2021 10:59:02 -0400 |
| |
On 8/5/21 5:04 AM, Thomas Gleixner wrote: > On Wed, Aug 04 2021 at 15:37, Waiman Long wrote: >> On 7/30/21 9:50 AM, Thomas Gleixner wrote: >>> +static int __sched rwbase_write_lock(struct rwbase_rt *rwb, >>> + unsigned int state) >>> +{ >>> + struct rt_mutex_base *rtm = &rwb->rtmutex; >>> + unsigned long flags; >>> + >>> + /* Take the rtmutex as a first step */ >>> + if (rwbase_rtmutex_lock_state(rtm, state)) >> This function is used here before it was defined in next patch (patch 16). > Correct and there are more I think. But that's a hen and egg > problem: > > The base code cannot be compiled without the actual implementation for > either rw_semaphore or rw_lock substitutions. The implementations cannot > be compiled without the base code. > > So I chose to split it up so the base logic is separate. > > Thanks, > I realize that after the fact that the code introduced by this patch won't be compiled until the later patch is merged. So it is all OK.
Thanks, Longman
| |