Messages in this thread | | | Date | Tue, 31 Aug 2021 22:53:24 +0200 | From | Andrew Lunn <> | Subject | Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id |
| |
> True, but then again, DT is a bit special, since it's not used only by Linux. > It's shared at least with BSDs and U-Boot, which most likely have independent > driver implementation. That's why it's good to have DT fixes referencing DT > related commits. As you said, DT described HW wrong. > > Looking at past Allwinner related DT commits regarding this issue, we were not > totally consistent. Most of them reference commit where emac node was > introduced in DT. But I also found a couple of commits which indeed have fixes > tag for bbc4d71d6354.
All true, and it is not a big deal if it does go back further. I don't care, we can let the Allwinner Maintainer decide. Ah, that is you :-)
I just want to try to keep it simple for somebody who is contributing their first Linux kernel patch. If it is good enough, i say accept it, and we can do a bit more education on the second contribution.
Andre
| |