lkml.org 
[lkml]   [2021]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] nvme-tcp: Do not reset transport on data digest errors
On Mon, Aug 30, 2021 at 06:38:28PM +0300, Sagi Grimberg wrote:
> > + if (req->status == cpu_to_le16(NVME_SC_SUCCESS))
>
> endian conversion a zero enum? looks weird..

I though it makes sense to stay consistent with the rest and don't make
it harder for the reader to figure out why this might not needed here.

And obviously the fear of the static code analyzers...

> But,
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Thanks!

\
 
 \ /
  Last update: 2021-08-30 17:51    [W:0.221 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site