Messages in this thread | | | Date | Mon, 30 Aug 2021 17:50:24 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH v6] nvme-tcp: Do not reset transport on data digest errors |
| |
On Mon, Aug 30, 2021 at 06:38:28PM +0300, Sagi Grimberg wrote: > > + if (req->status == cpu_to_le16(NVME_SC_SUCCESS)) > > endian conversion a zero enum? looks weird..
I though it makes sense to stay consistent with the rest and don't make it harder for the reader to figure out why this might not needed here.
And obviously the fear of the static code analyzers...
> But, > Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Thanks!
| |