lkml.org 
[lkml]   [2021]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled
Date


On 30/08/2021 15:32, Christoph Hellwig wrote:
> On Sat, Aug 28, 2021 at 09:04:41AM +0800, Li Zhijian wrote:
>> + if (!pte_devmap(pte) && pte_special(pte) &&
>> + !is_zero_pfn(pte_pfn(pte))) {
> Maybe this is a little too superficial and nitpicky, but I find the
> ordering of the checks a little strange. Why not do the pte_special
> first and then the exlusions from it later?
>
It sounds good to me, let's update it

Thanks
Zhijian

\
 
 \ /
  Last update: 2021-08-30 11:31    [W:0.114 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site