Messages in this thread Patch in this message | | | From | qiang.zhang@windrive ... | Subject | [PATCH v2] trace/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads() | Date | Tue, 31 Aug 2021 10:29:19 +0800 |
| |
From: "Qiang.Zhang" <qiang.zhang@windriver.com>
When start_kthread() return error, the cpus_read_unlock() need to be called.
Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations") Cc: <stable@vger.kernel.org> # v5.14+ Signed-off-by: Qiang.Zhang <qiang.zhang@windriver.com> --- v1->v2: Modify submission information and code style, add tags.
kernel/trace/trace_osnoise.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 65b08b8e5bf8..ce053619f289 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -1548,7 +1548,7 @@ static int start_kthread(unsigned int cpu) static int start_per_cpu_kthreads(struct trace_array *tr) { struct cpumask *current_mask = &save_cpumask; - int retval; + int retval = 0; int cpu; cpus_read_lock(); @@ -1568,13 +1568,13 @@ static int start_per_cpu_kthreads(struct trace_array *tr) retval = start_kthread(cpu); if (retval) { stop_per_cpu_kthreads(); - return retval; + break; } } cpus_read_unlock(); - return 0; + return retval; } #ifdef CONFIG_HOTPLUG_CPU -- 2.17.1
| |