Messages in this thread | | | From | Cong Wang <> | Date | Mon, 30 Aug 2021 18:18:33 -0700 | Subject | Re: [PATCH] net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed |
| |
On Mon, Aug 30, 2021 at 11:05 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Sun, 29 Aug 2021 23:58:01 +0800 Xiyu Yang wrote: > > The reference counting issue happens in one exception handling path of > > cbq_change_class(). When failing to get tcf_block, the function forgets > > to decrease the refcount of "rtab" increased by qdisc_put_rtab(), > > causing a refcount leak. > > > > Fix this issue by jumping to "failure" label when get tcf_block failed. > > > > Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn> > > Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Thanks.
| |