lkml.org 
[lkml]   [2021]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning
From
Date
On 8/30/21 2:11 AM, Geert Uytterhoeven wrote:
> If CONFIG_BLK_DEBUG_FS=n:
>
> block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
> 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
> | ^~~~~~~~~
>
> Fix this by moving dd_queued() just before the sole function that calls
> it.
>
> Fixes: 7b05bf771084ff78 ("Revert "block/mq-deadline: Prioritize high-priority requests"")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

The Fixes tag probably should be changed into the following:

Fixes: 38ba64d12d4c ("block/mq-deadline: Track I/O statistics")

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

\
 
 \ /
  Last update: 2021-08-31 01:23    [W:0.284 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site