Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 3 Aug 2021 20:27:14 +0200 | Subject | Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies |
| |
On Tue, Aug 3, 2021 at 7:19 PM Keller, Jacob E <jacob.e.keller@intel.com> wrote: > > On Tue, Aug 3, 2021 at 6:14 PM Richard Cochran <richardcochran@gmail.com> wrote:
> There is an alternative solution to fixing the imply keyword: > > Make the drivers use it properly by *actually* conditionally enabling the feature only when IS_REACHABLE, i.e. fix ice so that it uses IS_REACHABLE instead of IS_ENABLED, and so that its stub implementation in ice_ptp.h actually just silently does nothing but returns 0 to tell the rest of the driver things are fine.
I would consider IS_REACHABLE() part of the problem, not the solution, it makes things magically build, but then surprises users at runtime when they do not get the intended behavior.
Arnd
| |