lkml.org 
[lkml]   [2021]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled
On Fri, Aug 27, 2021 at 01:28:52PM -0300, Jason Gunthorpe wrote:
> > + /*
> > + * just bypass devmap pte such as DAX page when all pfn requested
> > + * flags(pfn_req_flags) are fulfilled.
> > + */
> > + if (pte_devmap(pte))
> > + goto out;
>
> I liked your ealier version better where this was added to the
> pte_special test - logically this is about disambiguating the
> pte_special and the devmap case as they are different things.

Yes, I think that is much more logical. Also please capitalize the
first word in multi-line comments.

\
 
 \ /
  Last update: 2021-08-27 19:47    [W:0.238 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site