lkml.org 
[lkml]   [2021]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC PATCH 0/2] improve io scheduler callback triggering
Date
From: Niklas Cassel <niklas.cassel@wdc.com>

Recently, there were some extra "dummy" data added into mq-deadline
rq->elv.priv, that was there for the solve purpose of working around
shortcomings in blk-mq (which called the scheduler callbacks even
for requests that bypassed the scheduler).

Fix blk-mq to behave in a more sane way with regards to scheduler
callback triggering, and remove the now unneeded rq->elv.priv magic.

BFQ should be able to perform a similar cleanup, and should be able
to drop this comment from the code:
https://github.com/torvalds/linux/blob/master/block/bfq-iosched.c#L6456-L6462

Considering that I'm quite unfamiliar with the BFQ code, I'd rather
someone who is a bit more familiar with BFQ performs that cleanup.


Kind regards,
Niklas

Niklas Cassel (2):
blk-mq: don't call callbacks for requests that bypassed the scheduler
Revert "mq-deadline: Fix request accounting"

block/blk-mq-sched.c | 20 ++++++++++++++++++++
block/blk-mq.c | 13 -------------
block/mq-deadline.c | 16 +++++-----------
include/linux/blkdev.h | 3 ++-
4 files changed, 27 insertions(+), 25 deletions(-)

--
2.31.1

\
 
 \ /
  Last update: 2021-08-27 14:41    [W:0.310 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site