Messages in this thread | | | From | Guenter Roeck <> | Date | Wed, 25 Aug 2021 08:00:50 -0700 | Subject | Re: [PATCH] platform/chrome: cros_ec_trace: Fix format warnings |
| |
On Mon, Aug 23, 2021 at 1:01 PM Gwendal Grignou <gwendal@chromium.org> wrote: > > Fix printf format issues in new tracing events. > > Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces") > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > --- > drivers/platform/chrome/cros_ec_trace.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h > index f50b9f9b8610..a2052db55671 100644 > --- a/drivers/platform/chrome/cros_ec_trace.h > +++ b/drivers/platform/chrome/cros_ec_trace.h > @@ -92,7 +92,7 @@ TRACE_EVENT(cros_ec_sensorhub_timestamp, > __entry->current_time = current_time; > __entry->delta = current_timestamp - current_time; > ), > - TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld", > + TP_printk("ec_ts: %9d, ec_fifo_ts: %9d, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
Should that be %u (the variables are u32) ?
> __entry->ec_sample_timestamp, > __entry->ec_fifo_timestamp, > __entry->fifo_timestamp, > @@ -122,7 +122,7 @@ TRACE_EVENT(cros_ec_sensorhub_data, > __entry->current_time = current_time; > __entry->delta = current_timestamp - current_time; > ), > - TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld", > + TP_printk("ec_num: %4d, ec_fifo_ts: %9d, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
Same here.
Thanks, Guenter
> __entry->ec_sensor_num, > __entry->ec_fifo_timestamp, > __entry->fifo_timestamp, > @@ -153,7 +153,7 @@ TRACE_EVENT(cros_ec_sensorhub_filter, > __entry->x = state->x_offset; > __entry->y = state->y_offset; > ), > - TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld", > + TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %lld x: %12lld y: %12lld", > __entry->dx, > __entry->dy, > __entry->median_m, > -- > 2.33.0.rc2.250.ged5fa647cd-goog >
| |