Messages in this thread | | | Date | Wed, 25 Aug 2021 15:04:23 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH v6 3/3] nvme-fc: Remove freeze/unfreeze around update_nr_hw_queues |
| |
On Tue, Aug 24, 2021 at 01:38:20PM -0700, Sagi Grimberg wrote: > > freeze before calling update_hr_hw_queues". It's not an exact revert as > > it leaves the adjusting of hw queues only if the count changes. > > I see that fc doesn't freeze the queues, so it obviously wrong to > unfreeze them. But is it correct to not freeze the queues?
nvme-fc is draining the queues in the error recovery path (__nvme_fc_abort_outstanding_ios). There are no request in the queues hence we don't have to freeze.
The only reason to keep the freeze/unfreeze in this path would be to make it look alike the other transport. But it would be a no-op.
| |