Messages in this thread | | | Subject | Re: [PATCH] tty: moxa: use semi-colons instead of commas | From | Jiri Slaby <> | Date | Wed, 25 Aug 2021 14:58:19 +0200 |
| |
On 25. 08. 21, 9:24, Dan Carpenter wrote: > This code works but it's cleaner to use a semi-colon to end a statement > instead of a comma. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
I just wonder why: tty: moxa: vs mxser: with no "tty: " ...
> --- > drivers/tty/moxa.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c > index 776f78de0f82..bf17e90858b8 100644 > --- a/drivers/tty/moxa.c > +++ b/drivers/tty/moxa.c > @@ -2034,10 +2034,10 @@ static int moxa_get_serial_info(struct tty_struct *tty, > if (!info) > return -ENODEV; > mutex_lock(&info->port.mutex); > - ss->type = info->type, > - ss->line = info->port.tty->index, > - ss->flags = info->port.flags, > - ss->baud_base = 921600, > + ss->type = info->type; > + ss->line = info->port.tty->index; > + ss->flags = info->port.flags; > + ss->baud_base = 921600; > ss->close_delay = jiffies_to_msecs(info->port.close_delay) / 10; > mutex_unlock(&info->port.mutex); > return 0; >
-- js suse labs
| |