Messages in this thread | | | From | "Fabio M. De Francesco" <> | Subject | Re: [PATCH 1/2] staging: r8188eu: Use usb_control_msg_recv/send() in usbctrl_vendorreq() | Date | Tue, 24 Aug 2021 10:53:11 +0200 |
| |
On Tuesday, August 24, 2021 10:13:46 AM CEST Pavel Skripkin wrote: > On 8/24/21 1:37 AM, Fabio M. De Francesco wrote: > > Replace usb_control_msg() with the new usb_control_msg_recv() and > > usb_control_msg_send() API of USB Core in usbctrl_vendorreq(). > > > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > > --- > > > > Thanks to Pavel Skripkin <paskripkin@gmail.com> for his review of the > > RFC patch. > > > > drivers/staging/r8188eu/hal/usb_ops_linux.c | 25 ++++++++++----------- > > 1 file changed, 12 insertions(+), 13 deletions(-) > > > > [...] > > > Hi, Fabio! > > Christophe is right about semantic part.
Hi Pavel,
I haven't yet read Christophe's message (but I'm going to do it ASAP). I hope he found out what is wrong with the code, what made Phil's tests fail.
> Also, > > if (!status) { > > } else { > if (status < 0) { <- > | > } else { | > | > } <- > } > > Extra if-else is not needed, since status can be 0 and < 0, there is no > 3rd state, like it was before.
Correct, thanks!
Now I read the following from the documentation of the new API...
"Return: If successful, 0 is returned, Otherwise, a negative error number."
I'll remove that status < 0 check and whatever else is no more necessary. Thanks, again :)
Regards,
Fabio
> With regards, > Pavel Skripkin >
| |