Messages in this thread | | | Date | Tue, 24 Aug 2021 00:01:56 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property |
| |
On Mon, Aug 23, 2021 at 01:48:23PM -0700, Saravana Kannan wrote: > On Mon, Aug 23, 2021 at 12:58 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > > PHY seems to be one of those cases where it's okay to have the > > > compatible property but also okay to not have it. > > > > Correct. They are like PCI or USB devices. You can ask it, what are > > you? There are two registers in standard locations which give you a > > vendor and product ID. We use that to find the correct driver. > > For all the cases of PHYs that currently don't need any compatible > string, requiring a compatible string of type "ethernet-phy-standard" > would have been nice.
How does this help you? You cannot match that against anything?
How do you handle PCI and USB devices? e.g.
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
&pcie { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pcie>; reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>; status = "okay";
host@0 { reg = <0 0 0 0 0>;
#address-cells = <3>; #size-cells = <2>;
i210: i210@0 { reg = <0 0 0 0 0>; }; }; };
There is an intel i210 Ethernet control on the PCIe bus. There is no compatible string, none is needed. This is no different to a PHY.
Andrew
| |