Messages in this thread | | | From | Stephen Boyd <> | Date | Mon, 23 Aug 2021 15:12:02 -0500 | Subject | Re: [PATCH v3 10/10] arm64: dts: qcom: sc7280: Update Q6V5 MSS node |
| |
Quoting Sibi Sankar (2021-08-18 20:36:25) > Update MSS node to support MSA based modem boot on SC7280 SoCs. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > v3: > * Place remoteproc_mpss node in alphabetical order above pinctrl > section. [Stephen] > > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 7 +++++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++++++--- > 2 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 103d89c1e1c7..f1c8641b0c26 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -263,6 +263,13 @@ > status = "okay"; > }; > > +&remoteproc_mpss { > + status = "okay"; > + compatible = "qcom,sc7280-mss-pil"; > + iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; > + memory-region = <&mba_mem &mpss_mem>;
Nitpick:
memory-region = <&mba_mem>, <&mpss_mem>;
would be better as it indicates that &mpss_mem isn't being parsed when &mba_mem is being parsed, i.e. they're independent phandles.
> +}; > + > &sdhc_1 { > status = "okay"; >
| |