Messages in this thread | | | Date | Mon, 23 Aug 2021 10:32:41 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 07/20] platform/x86: pmc_atom: Move to intel sub-directory |
| |
On Fri, Aug 20, 2021 at 08:18:17PM +0200, Hans de Goede wrote: > On 8/20/21 1:04 PM, Andy Shevchenko wrote: > > Move Intel Atom PMC driver to intel sub-directory to improve readability. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > This means that pmc_atom will now not be build if X86_PLATFORM_DRIVERS_INTEL > is not set (and PCI is enabled). Which will cause missing pmc_atom_read/_write > symbols in drivers/acpi/acpi_lpss.c. So I have dropped this patch from the > set, while applying the rest. > > Note I'm thinking that we should just remove the whole X86_PLATFORM_DRIVERS_INTEL > Kconfig option and in the drivers/platform/x86/Makefile replace: > > obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ > > with: > > obj-y += intel/ > > This will also allows us to fix the scu issue without needing any > changes to drivers/mfd/Kconfig . > > But this can all wait for the 2nd round of renames after 5.15-rc1. > > For now I'm moving forward with this v5 series, except with this > patch dropped.
Indeed. Thanks for the analysis.
Btw, should we convert Dell subdir to something similar in terms of Kconfig?
-- With Best Regards, Andy Shevchenko
| |