lkml.org 
[lkml]   [2021]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 07/20] platform/x86: pmc_atom: Move to intel sub-directory
On Fri, Aug 20, 2021 at 08:18:17PM +0200, Hans de Goede wrote:
> On 8/20/21 1:04 PM, Andy Shevchenko wrote:
> > Move Intel Atom PMC driver to intel sub-directory to improve readability.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> This means that pmc_atom will now not be build if X86_PLATFORM_DRIVERS_INTEL
> is not set (and PCI is enabled). Which will cause missing pmc_atom_read/_write
> symbols in drivers/acpi/acpi_lpss.c. So I have dropped this patch from the
> set, while applying the rest.
>
> Note I'm thinking that we should just remove the whole X86_PLATFORM_DRIVERS_INTEL
> Kconfig option and in the drivers/platform/x86/Makefile replace:
>
> obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/
>
> with:
>
> obj-y += intel/
>
> This will also allows us to fix the scu issue without needing any
> changes to drivers/mfd/Kconfig .
>
> But this can all wait for the 2nd round of renames after 5.15-rc1.
>
> For now I'm moving forward with this v5 series, except with this
> patch dropped.

Indeed. Thanks for the analysis.

Btw, should we convert Dell subdir to something similar in terms of Kconfig?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-08-23 09:33    [W:0.082 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site