Messages in this thread Patch in this message | | | From | Brad Larson <> | Date | Mon, 23 Aug 2021 09:30:47 -0700 | Subject | Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control |
| |
Hi Geert,
On Mon, Aug 23, 2021 at 12:50 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Brad, > > On Mon, Aug 23, 2021 at 3:14 AM Brad Larson <brad@pensando.io> wrote: > > On Mon, Mar 29, 2021 at 3:40 AM Andy Shevchenko [...] > > Regarding the above module question and Kconfig definition, since I > > first looked at this and reviewed the comments I realized I should be > > using builtin. The file gpio/Kconfig is currently this > > > > config GPIO_ELBA_SPICS > > def_bool y > > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST > > That means the driver will default to yes by merely enabling > COMPILE_TEST, which is a no-go. > > config GPIO_ELBA_SPICS > bool "one-line summary" > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST > default y if ARCH_PENSANDO_ELBA_SOC
Thanks Geert, changed to this
--- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -241,8 +241,9 @@ config GPIO_EIC_SPRD Say yes here to support Spreadtrum EIC device.
config GPIO_ELBA_SPICS + bool "Pensando Elba SoC SPI Chip Select as GPIO support" + depends on ARCH_PENSANDO_ELBA_SOC def_bool y - depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST
Regards, Brad
| |