Messages in this thread | | | Date | Mon, 23 Aug 2021 12:33:18 +0300 | From | Andy Shevchenko <> | Subject | Re: [RFT, PATCH v1 1/1] platform/x86: hp_accel: Convert to be a platform driver |
| |
On Fri, Aug 06, 2021 at 03:42:40PM +0200, Hans de Goede wrote: > Hi, > > On 8/3/21 10:08 PM, Andy Shevchenko wrote: > > ACPI core in conjunction with platform driver core provides > > an infrastructure to enumerate ACPI devices. Use it in order > > to remove a lot of boilerplate code. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > > > Not sure what buys us to run _INI on PM calls. It's against the spec AFAICT. > > In any case ACPICA runs _INI as per specification when devices are > > instantiated. > > _INI used to also be ran on resume for some reason, but that was recently > changed. > > You're right that calling it is no longer necessary now that we no longer > do that. > > But the changes related to this are really separate from the platform > driver conversion, please split this into 2 patches. > > Also for the next version please Cc: Kai-Heng Feng <kai.heng.feng@canonical.com> > and ask him to test, I think he has access to hardware to test this.
v2 has been sent.
-- With Best Regards, Andy Shevchenko
| |