Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Mon, 23 Aug 2021 10:06:43 +0200 | Subject | Re: [PATCH 0/3] gpio: mpc8xxx: Fix 3 errors related to the error handling path of the 'mpc8xxx_probe()' |
| |
On Fri, Aug 20, 2021 at 5:37 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > This has been split in 3 patches because: > - the root issue of patch 1 and 3 is not the same commit as the one for patch 2. > - the strategy to fix the issues is not the same > - patch 1: add a new call in the rror handling path > - patch 3: switch to a resource managed function > > They could be merged together if easier to review. The subject would then be > something like "gpio: mpc8xxx: Fix the error handling path of 'mpc8xxx_probe()'" > > If prefered, 'devm_add_action_or_reset()' could be used to switch the probe to > a fully managed resource function and remove the 'remove' function. > That's mostly a matter of taste. > > If such an option is preferred, I'm a bit puzzled by the > 'irq_set_chained_handler_and_data()' call in the remove function because I > don't see why it is there. > Also see the comment at the end of patch 1 also related to this function call. > > > Christophe JAILLET (3): > gpio: mpc8xxx: Fix a resources leak in the error handling path of > 'mpc8xxx_probe()' > gpio: mpc8xxx: Fix a potential double iounmap call in > 'mpc8xxx_probe()' > gpio: mpc8xxx: Use 'devm_gpiochip_add_data()' to simplify the code and > avoid a leak > > drivers/gpio/gpio-mpc8xxx.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > -- > 2.30.2 >
Hi Christophe,
These look good but I'm leaving for a couple days in an hour so I won't be able to send a PR to Linus before the next release. I'll make these part of my regular PR for the upcoming merge window.
Bart
| |