Messages in this thread | | | Subject | Re: [PATCH] x86/kdump: fix wrong judge about crash_size var | From | Xin Hao <> | Date | Tue, 24 Aug 2021 10:31:28 +0800 |
| |
Hi, everyone:
Why nobody review this patch?
在 2021/8/13 下午3:12, Xin Hao 写道: > The type of crash_size is unsigned long long, so > it can not be less than 0, so there fix it. > > Signed-off-by: Xin Hao <xhao@linux.alibaba.com> > --- > arch/x86/kernel/setup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index bff3a784aec5..95b80ec11741 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -472,11 +472,11 @@ static void __init reserve_crashkernel(void) > > /* crashkernel=XM */ > ret = parse_crashkernel(boot_command_line, total_mem, &crash_size, &crash_base); > - if (ret != 0 || crash_size <= 0) { > + if (ret != 0 || !crash_size) { > /* crashkernel=X,high */ > ret = parse_crashkernel_high(boot_command_line, total_mem, > &crash_size, &crash_base); > - if (ret != 0 || crash_size <= 0) > + if (ret != 0 || !crash_size) > return; > high = true; > } > -- > 2.31.0
-- Best Regards! Xin Hao
| |