lkml.org 
[lkml]   [2021]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/6] phy: dt-bindings: cdns,dphy: make clocks optional
Hi Pratyush,

Thank you for the patch.

On Sat, Aug 21, 2021 at 12:33:44AM +0530, Pratyush Yadav wrote:
> The clocks are not used by the DPHY when used in Rx mode so make them
> optional.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> Acked-by: Rob Herring <robh@kernel.org>
>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> - Add Rob's Ack.
>
> Changes in v2:
> - Re-order subject prefixes.
>
> Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> index b90a58773bf2..3bb5be05e825 100644
> --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> @@ -33,8 +33,6 @@ properties:
> required:
> - compatible
> - reg
> - - clocks
> - - clock-names

Could you turn this into a conditional requirement based on the compat
string, as the clocks are needed in the TX case ?

> - "#phy-cells"
>
> additionalProperties: false

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2021-08-23 03:41    [W:0.073 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site