Messages in this thread | | | Subject | Re: [PATCH] nvme-tcp: Do not reset transport on data digest errors | From | Hannes Reinecke <> | Date | Fri, 20 Aug 2021 12:20:43 +0200 |
| |
On 8/5/21 2:15 PM, Daniel Wagner wrote: > The spec says > > 7.4.6.1 Digest Error handling > > When a host detects a data digest error in a C2HData PDU, that host > shall continue processing C2HData PDUs associated with the command and > when the command processing has completed, if a successful status was > returned by the controller, the host shall fail the command with a > non-fatal transport error. > > Currently the transport is reseted when a data digest error is > detected. To fix this, keep track of the final status in the queue > object and use it when completing the request. > > The new member can be placed adjacent to the receive related members and > fits in the cacheline as there is a 4 byte hole. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
| |